FrankChen021 commented on PR #19910: URL: https://github.com/apache/druid/pull/19910#issuecomment-5210124550
Fixed and pushed as 5cfd2c53e0. CI failure: testCompile could not access org.hamcrest.DiagnosingMatcher and org.hamcrest.Matcher at SegmentTransactionalInsertActionTest.java:234 and ConcurrentReplaceAndAppendTest.java:1213 after PR #19875 removed Hamcrest from the shared processing test classpath. The two requested files now use JUnit5Assertions, JUnit5Matchers, and direct DruidException field assertions. No dependencies or other modules changed. Validation: - Focused source compilation of both changed tests and test-source dependencies passed. - Surefire passed: 36 tests, 0 failures/errors (32 ConcurrentReplaceAndAppendTest; 4 SegmentTransactionalInsertActionTest). - mvn -pl indexing-service -am -DskipTests -Dweb.console.skip=true -T1C validate passed: Checkstyle 0 violations; PMD and Enforcer passed. - mvn -pl indexing-service -am -DskipTests -Dweb.console.skip=true -T1C compile passed: forbidden-API scans 0 errors. - Indexing-service audit found no JUnit4/Hamcrest imports or direct dependency declarations; git diff --check passed. The full reactor testCompile on this standalone checkout still stops at inherited KillUnusedSegmentsTaskTest.java:407 because PR #19875 custom processing matcher sources are not present locally. That unrelated file/module was not modified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
