FrankChen021 commented on PR #19910: URL: https://github.com/apache/druid/pull/19910#issuecomment-5210332578
Follow-up pushed as `00cd6a1256`. The remaining CI failure was caused by all indexing-service test consumers of `org.apache.druid.error.DruidExceptionMatcher` resolving the old processing test-jar matcher, which extends Hamcrest. I migrated all 26 consumers across 11 indexing-service test classes to the existing Hamcrest-free `JUnit5Matchers` helper. The local matcher checks the same DruidException target persona, category, error code, and exact message. No processing, server, SQL, or contrib files were modified, and no Hamcrest dependency was restored. Validation on the pushed tree: - Full reactor `test-compile` (`mvn -pl indexing-service -am -DskipTests test-compile -Dweb.console.skip=true -T1C`): passed all six modules and compiled all 258 indexing-service test sources. - Focused Surefire run covering the two original direct-fix tests and all 11 migrated consumer classes: 316 passed, 0 failures, 0 errors, with no additional Hamcrest classpath. - Non-skipped reactor validation/static goals: passed Checkstyle (0 violations), PMD, Enforcer, and forbidden-API scans (0 errors). - Final indexing-service test compilation: passed Checkstyle (0 violations) and test forbidden-API scan (0 errors). - Source audit over `indexing-service/src` and `indexing-service/pom.xml`: 0 `DruidExceptionMatcher`, `ExceptionMatcher`, JUnit4, or Hamcrest references. - Test dependency-tree audit for Hamcrest and JUnit4/vintage artifacts: no matches. - `git diff --check`: passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
