FrankChen021 commented on PR #19910: URL: https://github.com/apache/druid/pull/19910#issuecomment-5210197216
Follow-up pushed as `c4c7fcaffc`. Audited all indexing-service test consumers of `org.apache.druid.error.ExceptionMatcher` (the remaining consumers were `KillUnusedSegmentsTaskTest` and `GlobalTaskLockboxTest`) and migrated both to `JUnit5Assertions` plus `JUnit5Matchers`. No Hamcrest or JUnit 4 dependency was added, and no other module was changed. Validation: - `mvn -pl indexing-service -am -DskipTests test-compile -Pskip-static-checks -Dweb.console.skip=true -T1C`: this standalone checkout now advances past the former `ExceptionMatcher` failures, then stops at the inherited `KillUnusedSegmentsTaskTest.java:1290` `DruidExceptionMatcher` fixture. That custom processing fixture is supplied by PR #19875 but is not present in this checkout; no new follow-up failure occurs in either migrated test. - Focused Surefire coverage: 45 tests passed, 0 failures, 0 errors across the affected tests and related existing fixtures. A temporary Hamcrest runtime classpath was used only for the two stale pre-#19875 `DruidExceptionMatcher` fixtures; no project dependency or source reference was added. - `mvn -pl indexing-service -am -DskipTests -Dweb.console.skip=true -T1C validate compile`: passed Checkstyle, PMD/Enforcer, and forbidden-API checks. - Exact `ExceptionMatcher` source audit: 0 indexing-service test imports/usages. - JUnit 4/Hamcrest source audit: 0 matches in `indexing-service/src/test` and `indexing-service/pom.xml`. - Test dependency-tree audit for `org.hamcrest:*`: no indexing-service dependency. - `git diff --check`: passed. The branch contains only the intended two follow-up test-file changes on top of the prior direct assertion fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
