surekhasaharan commented on a change in pull request #7595: Optimize
overshadowed segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r282291730
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorRuleRunner.java
##########
@@ -84,8 +85,10 @@ public DruidCoordinatorRuntimeParams
run(DruidCoordinatorRuntimeParams params)
// find available segments which are not overshadowed by other segments in
DB
// only those would need to be loaded/dropped
// anything overshadowed by served segments is dropped automatically by
DruidCoordinatorCleanupOvershadowed
- final Set<DataSegment> overshadowed = ImmutableDruidDataSource
- .determineOvershadowedSegments(params.getAvailableSegments());
+ // If metadata store hasn't been polled yet, use empty overshadowed list
+ final Collection<DataSegment> overshadowed = Optional
+
.ofNullable(coordinator.getMetadataSegmentManager().findOvershadowedSegments())
Review comment:
If it's acceptable to get updated overshadowedSegments in the next run of
`DruidCoordinatorHelper#run`, then I think it might be ok. If not, then may be
we should compute the overshadowed list here itself, like before, until the
mutability of `DataSegment` is settled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
