surekhasaharan commented on a change in pull request #7595: Optimize
overshadowed segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288223717
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
##########
@@ -744,6 +755,35 @@ public DataSegment map(int index, ResultSet r,
StatementContext ctx) throws SQLE
// Replace "dataSources" atomically.
Review comment:
@leventov aren't you suggesting the same thing in [#7571
(comment)](https://github.com/apache/incubator-druid/issues/7571#issuecomment-495738096),
with your first suggestion and your second suggestion
> but this problem naturally goes away itself when SQLSegmentMetadataManager
will store SegmentWithOvershadowedStatus objects in dataSources
I'm not sure I understand it, so did you mean to store
`SegmentWithOvershadowedStatus`(set of overshadowed segments) in
`DruidDataSource` object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
