surekhasaharan commented on a change in pull request #7595: Optimize
overshadowed segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r282204314
##########
File path:
core/src/main/java/org/apache/druid/timeline/DataSegmentWithOvershadowedStatus.java
##########
@@ -25,16 +25,16 @@
/**
* DataSegment object plus the overshadowed status for the segment. An
immutable object.
*
- * SegmentWithOvershadowedStatus's {@link #compareTo} method considers only
the {@link SegmentId}
+ * DataSegmentWithOvershadowedStatus's {@link #compareTo} method considers
only the {@link SegmentId}
* of the DataSegment object.
*/
-public class SegmentWithOvershadowedStatus implements
Comparable<SegmentWithOvershadowedStatus>
+public class DataSegmentWithOvershadowedStatus implements
Comparable<DataSegmentWithOvershadowedStatus>
Review comment:
hmm, since it's a wrapper on DataSegment, that's why I felt this might make
more sense, i'd be okay reverting it back to `SegmentWithOvershadowedStatus` if
there are plans to rename `DataSegment` , although that seems unclear at this
point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
