surekhasaharan commented on a change in pull request #7595: Optimize
overshadowed segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288353256
##########
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
##########
@@ -744,6 +755,35 @@ public DataSegment map(int index, ResultSet r,
StatementContext ctx) throws SQLE
// Replace "dataSources" atomically.
Review comment:
created a `DataSourceSnapshot` class which contains a snapshot of
druidDatasources and computes the overshadowed segment from that snapshot, this
is invoked from `doPoll()`, so both dataSources and overshadowedSegments are
updated atomically in every poll cycle. And the getters like `getDataSources`
and `getOvershadowedSegments` use this snapshot class to return the values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
