leventov commented on a change in pull request #8089: add CachingClusteredClient benchmark, refactor some stuff URL: https://github.com/apache/incubator-druid/pull/8089#discussion_r304447172
########## File path: core/src/main/java/org/apache/druid/collections/CombiningFunction.java ########## @@ -17,11 +17,10 @@ * under the License. */ -package org.apache.druid.java.util.common.guava.nary; +package org.apache.druid.collections; -/** - */ -public interface BinaryFn<Type1, Type2, OutType> +@FunctionalInterface +public interface CombiningFunction<T> Review comment: Please use the standard [`BinaryOperator`](https://docs.oracle.com/javase/8/docs/api/java/util/function/BinaryOperator.html) or add a Javadoc comment justifying the existence of `CombiningFunction`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
