leventov commented on a change in pull request #8089: add
CachingClusteredClient benchmark, refactor some stuff
URL: https://github.com/apache/incubator-druid/pull/8089#discussion_r304469064
##########
File path:
core/src/main/java/org/apache/druid/collections/CombiningIterable.java
##########
@@ -51,37 +50,32 @@
return create(
new MergeIterable<InType>(comparator, (Iterable<Iterable<InType>>) in),
comparator,
- new BinaryFn<InType, InType, InType>()
- {
- @Override
- public InType apply(InType arg1, InType arg2)
- {
- if (arg1 == null) {
- return arg2;
- }
- return arg1;
+ (arg1, arg2) -> {
Review comment:
Could you please extract `GuavaUtils.firstNonNull` and use a method
reference here? The doc for that method should note that
`Objects.firstNonNull()` cannot be used itself because it's one of those
methods causing Guava incompatibility (see #6948). Please also add Guava's
`Objects.firstNonNull()` this method to forbidden-apis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
