leventov commented on a change in pull request #8089: add
CachingClusteredClient benchmark, refactor some stuff
URL: https://github.com/apache/incubator-druid/pull/8089#discussion_r304463168
##########
File path: server/src/main/java/org/apache/druid/client/BrokerServerView.java
##########
@@ -108,25 +108,18 @@ public BrokerServerView(
this.selectors = new HashMap<>();
this.timelines = new HashMap<>();
- this.segmentFilter = new Predicate<Pair<DruidServerMetadata,
DataSegment>>()
- {
- @Override
- public boolean apply(
- Pair<DruidServerMetadata, DataSegment> input
- )
- {
- if (segmentWatcherConfig.getWatchedTiers() != null
- &&
!segmentWatcherConfig.getWatchedTiers().contains(input.lhs.getTier())) {
- return false;
- }
-
- if (segmentWatcherConfig.getWatchedDataSources() != null
- &&
!segmentWatcherConfig.getWatchedDataSources().contains(input.rhs.getDataSource()))
{
- return false;
- }
+ this.segmentFilter = metadataAndSegment -> {
Review comment:
Type of `metadataAndSegment` is not obvious, please use
`(Pair<DruidServerMetadata, DataSegment> metadataAndSegment) -> ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
