leventov commented on a change in pull request #8089: add
CachingClusteredClient benchmark, refactor some stuff
URL: https://github.com/apache/incubator-druid/pull/8089#discussion_r304458633
##########
File path:
processing/src/main/java/org/apache/druid/query/topn/TopNQueryQueryToolChest.java
##########
@@ -109,36 +108,27 @@ public TopNQueryQueryToolChest(
}
@Override
- public QueryRunner<Result<TopNResultValue>> mergeResults(
- QueryRunner<Result<TopNResultValue>> runner
+ public CombiningFunction<Result<TopNResultValue>> createMergeFn(
+ Query<Result<TopNResultValue>> query
)
{
- return new ResultMergeQueryRunner<Result<TopNResultValue>>(runner)
- {
- @Override
- protected Ordering<Result<TopNResultValue>>
makeOrdering(Query<Result<TopNResultValue>> query)
- {
- return ResultGranularTimestampComparator.create(
- ((TopNQuery) query).getGranularity(), query.isDescending()
- );
- }
+ TopNQuery topNQuery = (TopNQuery) query;
+ return new TopNBinaryFn(
+ topNQuery.getGranularity(),
+ topNQuery.getDimensionSpec(),
+ topNQuery.getTopNMetricSpec(),
+ topNQuery.getThreshold(),
+ topNQuery.getAggregatorSpecs(),
+ topNQuery.getPostAggregatorSpecs()
+ );
+ }
- @Override
- protected BinaryFn<Result<TopNResultValue>, Result<TopNResultValue>,
Result<TopNResultValue>> createMergeFn(
- Query<Result<TopNResultValue>> input
- )
- {
- TopNQuery query = (TopNQuery) input;
- return new TopNBinaryFn(
- query.getGranularity(),
- query.getDimensionSpec(),
- query.getTopNMetricSpec(),
- query.getThreshold(),
- query.getAggregatorSpecs(),
- query.getPostAggregatorSpecs()
- );
- }
- };
+ @Override
+ public Ordering<Result<TopNResultValue>>
createOrderingFn(Query<Result<TopNResultValue>> query)
+ {
+ return ResultGranularTimestampComparator.create(
+ ((TopNQuery) query).getGranularity(), query.isDescending()
Review comment:
Please chop down `query.isDescending()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
