leventov commented on a change in pull request #8060: 6855 add Checkstyle for
constant name static final
URL: https://github.com/apache/incubator-druid/pull/8060#discussion_r311182004
##########
File path:
processing/src/test/java/org/apache/druid/query/QueryRunnerTestHelper.java
##########
@@ -88,48 +88,48 @@
public static final QueryWatcher NOOP_QUERYWATCHER = (query, future) -> {
};
- public static final String dataSource = "testing";
- public static final Interval fullOnInterval =
Intervals.of("1970-01-01T00:00:00.000Z/2020-01-01T00:00:00.000Z");
- public static final SegmentId segmentId = SegmentId.of(dataSource,
fullOnInterval, "dummy_version", 0);
- public static final UnionDataSource unionDataSource = new UnionDataSource(
- Stream.of(dataSource, dataSource, dataSource,
dataSource).map(TableDataSource::new).collect(Collectors.toList())
+ public static final String DATA_SOURCE = "testing";
+ public static final Interval FULL_ON_INTERVAL =
Intervals.of("1970-01-01T00:00:00.000Z/2020-01-01T00:00:00.000Z");
+ public static final SegmentId SEGMENT_ID = SegmentId.of(DATA_SOURCE,
FULL_ON_INTERVAL, "dummy_version", 0);
+ public static final UnionDataSource UNION_DATA_SOURCE = new UnionDataSource(
+ Stream.of(DATA_SOURCE, DATA_SOURCE, DATA_SOURCE,
DATA_SOURCE).map(TableDataSource::new).collect(Collectors.toList())
);
- public static final Granularity dayGran = Granularities.DAY;
- public static final Granularity allGran = Granularities.ALL;
- public static final Granularity monthGran = Granularities.MONTH;
- public static final String timeDimension = "__time";
- public static final String marketDimension = "market";
- public static final String qualityDimension = "quality";
- public static final String placementDimension = "placement";
- public static final String placementishDimension = "placementish";
- public static final String partialNullDimension = "partial_null_column";
-
- public static final List<String> dimensions = Lists.newArrayList(
- marketDimension,
- qualityDimension,
- placementDimension,
- placementishDimension
+ public static final Granularity DAY_GRAN = Granularities.DAY;
+ public static final Granularity ALL_GRAN = Granularities.ALL;
+ public static final Granularity MONTH_GRAN = Granularities.MONTH;
+ public static final String TIME_DIMENSION = "__time";
+ public static final String MARKET_DIMENSION = "market";
+ public static final String QUALITY_DIMENSION = "quality";
+ public static final String PLACEMENT_DIMENSION = "placement";
+ public static final String PLACEMENTISH_DIMENSION = "placementish";
+ public static final String PARTIAL_NULL_DIMENSION = "partial_null_column";
+
+ public static final List<String> DIMENSIONS = Lists.newArrayList(
+ MARKET_DIMENSION,
+ QUALITY_DIMENSION,
+ PLACEMENT_DIMENSION,
+ PLACEMENTISH_DIMENSION
);
- public static final String indexMetric = "index";
- public static final String uniqueMetric = "uniques";
- public static final String addRowsIndexConstantMetric =
"addRowsIndexConstant";
+ public static final String INDEX_METRIC = "index";
+ public static final String UNIQUE_METRIC = "uniques";
+ public static final String ADD_ROWS_INDEX_CONSTANT_METRIC =
"addRowsIndexConstant";
public static String dependentPostAggMetric = "dependentPostAgg";
- public static final CountAggregatorFactory rowsCount = new
CountAggregatorFactory("rows");
- public static final LongSumAggregatorFactory indexLongSum = new
LongSumAggregatorFactory("index", indexMetric);
- public static final LongSumAggregatorFactory __timeLongSum = new
LongSumAggregatorFactory("sumtime", timeDimension);
- public static final DoubleSumAggregatorFactory indexDoubleSum = new
DoubleSumAggregatorFactory("index", indexMetric);
+ public static final CountAggregatorFactory ROWS_COUNT = new
CountAggregatorFactory("rows");
+ public static final LongSumAggregatorFactory INDEX_LONG_SUM = new
LongSumAggregatorFactory("index", INDEX_METRIC);
+ public static final LongSumAggregatorFactory TIME_LONG_SUM = new
LongSumAggregatorFactory("sumtime", TIME_DIMENSION);
+ public static final DoubleSumAggregatorFactory INDEX_DOUBLE_SUM = new
DoubleSumAggregatorFactory("index", INDEX_METRIC);
public static final String JS_COMBINE_A_PLUS_B = "function combine(a, b) {
return a + b; }";
public static final String JS_RESET_0 = "function reset() { return 0; }";
- public static final JavaScriptAggregatorFactory jsIndexSumIfPlacementishA =
new JavaScriptAggregatorFactory(
+ public static final JavaScriptAggregatorFactory
JS_INDEX_SUM_IF_PLACEMENT_IS_HA = new JavaScriptAggregatorFactory(
Review comment:
`JS_INDEX_SUM_IF_PLACEMENTISH_A`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
