leventov commented on a change in pull request #8060: 6855 add Checkstyle for
constant name static final
URL: https://github.com/apache/incubator-druid/pull/8060#discussion_r311176118
##########
File path:
processing/src/main/java/org/apache/druid/query/topn/PooledTopNAlgorithm.java
##########
@@ -68,38 +68,38 @@
@VisibleForTesting
static void setSpecializeGeneric1AggPooledTopN(boolean value)
{
- PooledTopNAlgorithm.specializeGeneric1AggPooledTopN = value;
+ PooledTopNAlgorithm.SPECIALIZE_GENERIC_ONE_AGG_POOLED_TOPN = value;
computeSpecializedScanAndAggregateImplementations();
}
@VisibleForTesting
static void setSpecializeGeneric2AggPooledTopN(boolean value)
{
- PooledTopNAlgorithm.specializeGeneric2AggPooledTopN = value;
+ PooledTopNAlgorithm.SPECIALIZE_GENERIC_TWO_AGG_POOLED_TOPN = value;
computeSpecializedScanAndAggregateImplementations();
}
@VisibleForTesting
static void setSpecializeHistorical1SimpleDoubleAggPooledTopN(boolean value)
{
- PooledTopNAlgorithm.specializeHistorical1SimpleDoubleAggPooledTopN = value;
+
PooledTopNAlgorithm.SPECIALIZE_HISTORICAL_ONE_SIMPLE_DOUBLE_AGG_POOLED_TOPN =
value;
computeSpecializedScanAndAggregateImplementations();
}
@VisibleForTesting
static void
setSpecializeHistoricalSingleValueDimSelector1SimpleDoubleAggPooledTopN(boolean
value)
{
-
PooledTopNAlgorithm.specializeHistoricalSingleValueDimSelector1SimpleDoubleAggPooledTopN
= value;
+
PooledTopNAlgorithm.SPECIALIZE_HISTORICAL_SINGLE_VALUE_DIM_SELECTOR_ONE_SIMPLE_DOUBLE_AGG_POOLED_TOPN
= value;
computeSpecializedScanAndAggregateImplementations();
}
- private static final Generic1AggPooledTopNScanner defaultGeneric1AggScanner =
+ private static final Generic1AggPooledTopNScanner
DEFAULT_GENERIC1_AGG_SCANNER =
Review comment:
This is inconsistent with other renames in this class which translate 1 to
`_ONE_`. Also in 3 renames below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
