leventov commented on a change in pull request #8209: add mechanism to control
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r311680045
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/SpatialDimFilter.java
##########
@@ -20,35 +20,49 @@
package org.apache.druid.query.filter;
import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
+import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableSet;
import com.google.common.collect.RangeSet;
-import com.google.common.collect.Sets;
import org.apache.druid.collections.spatial.search.Bound;
import org.apache.druid.java.util.common.StringUtils;
import org.apache.druid.segment.filter.SpatialFilter;
+import javax.annotation.Nullable;
import java.nio.ByteBuffer;
-import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
/**
*/
public class SpatialDimFilter implements DimFilter
{
private final String dimension;
private final Bound bound;
+ @Nullable
+ private final FilterTuning filterTuning;
Review comment:
There is significant repetition between all these Filter implementations.
Did you research if there is a way to cross-cut the things, e. g. by somehow
providing `filterTuning` externally, so that each Filter doesn't have to have
it as a field? Or, maybe an abstract superclass could be extracted?
Same applies to `extractionFn`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
