leventov commented on a change in pull request #8209: add mechanism to control
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r312203240
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/ColumnComparisonFilter.java
##########
@@ -148,9 +148,9 @@ public boolean supportsBitmapIndex(BitmapIndexSelector
selector)
}
@Override
- public boolean shouldUseIndex(BitmapIndexSelector bitmapIndexSelector)
+ public boolean shouldUseBitmapIndex(BitmapIndexSelector selector)
{
- return Filters.shouldUseIndex(this, bitmapIndexSelector, filterTuning);
+ return Filters.shouldUseBitmapIndex(this, selector, filterTuning);
Review comment:
It's confusing that this method doesn't just return `false` while
`supportsBitmapIndex()` does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
