leventov commented on a change in pull request #8209: add mechanism to control
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r311683260
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/AndFilter.java
##########
@@ -125,6 +125,17 @@ public boolean canVectorizeMatcher()
return filters.stream().allMatch(Filter::canVectorizeMatcher);
}
+ @Override
+ public boolean shouldUseIndex(BitmapIndexSelector bitmapIndexSelector)
Review comment:
Since `shouldUseIndex` related to `supportsBitmapIndex` and their
implementations look similar, please keep them adjacent in code. It makes
easier to visually validate that there are no bugs like forgetting `!`.
Same applies to all other classes where `shouldUseIndex` is implemented, and
to the definition of this method in `Filter` interface itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
