leventov commented on a change in pull request #8209: add mechanism to control
filter optimization in historical query processing
URL: https://github.com/apache/incubator-druid/pull/8209#discussion_r311674741
##########
File path:
processing/src/main/java/org/apache/druid/query/filter/InDimFilter.java
##########
@@ -73,7 +78,8 @@
public InDimFilter(
@JsonProperty("dimension") String dimension,
@JsonProperty("values") Collection<String> values,
- @JsonProperty("extractionFn") ExtractionFn extractionFn
+ @Nullable @JsonProperty("extractionFn") ExtractionFn extractionFn,
Review comment:
Optional: I think it's more semantic to put `@Nullable` immediately before
the type so that `@Nullable ExtractionFn` is the "extended type" of the
variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
