leventov commented on a change in pull request #8564: Fix ambiguity about
IndexerSQLMetadataStorageCoordinator.getUsedSegmentsForInterval() returning
only non-overshadowed or all used segments
URL: https://github.com/apache/incubator-druid/pull/8564#discussion_r340658583
##########
File path:
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java
##########
@@ -177,6 +175,32 @@ public void start()
final String dataSource,
final List<Interval> intervals
)
+ {
+ Query<Map<String, Object>> sql =
createUsedSegmentsSqlQueryForIntervals(handle, dataSource, intervals);
+
+ try (final ResultIterator<byte[]> dbSegments =
sql.map(ByteArrayMapper.FIRST).iterator()) {
+ return VersionedIntervalTimeline.forSegments(
+ Iterators.transform(dbSegments, payload ->
JacksonUtils.readValue(jsonMapper, payload, DataSegment.class))
+ );
+ }
+ }
+
+ private Collection<DataSegment> getAllUsedSegmentsForIntervalsWithHandle(
+ final Handle handle,
+ final String dataSource,
+ final List<Interval> intervals
+ )
+ {
+ return createUsedSegmentsSqlQueryForIntervals(handle, dataSource,
intervals)
+ .map((index, r, ctx) -> JacksonUtils.readValue(jsonMapper,
r.getBytes("payload"), DataSegment.class))
+ .list();
+ }
+
+ private Query<Map<String, Object>> createUsedSegmentsSqlQueryForIntervals(
Review comment:
Added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
