leventov commented on a change in pull request #8564: Fix ambiguity about
IndexerSQLMetadataStorageCoordinator.getUsedSegmentsForInterval() returning
only non-overshadowed or all used segments
URL: https://github.com/apache/incubator-druid/pull/8564#discussion_r340660374
##########
File path:
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java
##########
@@ -36,41 +37,63 @@
public interface IndexerMetadataStorageCoordinator
{
/**
- * Get all segments which may include any data in the interval and are
flagged as used.
+ * Get all segments which may include any data in the interval and are
marked as used.
*
- * @param dataSource The datasource to query
- * @param interval The interval for which all applicable and used
datasources are requested. Start is inclusive, end is exclusive
- *
- * @return The DataSegments which include data in the requested interval.
These segments may contain data outside the requested interval.
+ * The order of segments within the returned collection is unspecified, but
each segment is guaranteed to appear in
+ * the collection only once.
*
- * @throws IOException
+ * @param dataSource The datasource to query
+ * @param interval The interval for which all applicable and used
datasources are requested. Start is inclusive,
+ * end is exclusive
+ * @param visibility Whether only visible or visible as well as overshadowed
segments should be returned. The
+ * visibility is considered within the specified interval:
that is, a segment which is globally
Review comment:
Reworded to "visible outside of the specified interval(s)"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
