leventov commented on a change in pull request #8564: Fix ambiguity about
IndexerSQLMetadataStorageCoordinator.getUsedSegmentsForInterval() returning
only non-overshadowed or all used segments
URL: https://github.com/apache/incubator-druid/pull/8564#discussion_r340658231
##########
File path: core/src/main/java/org/apache/druid/timeline/Partitions.java
##########
@@ -17,28 +17,16 @@
* under the License.
*/
-package org.apache.druid.indexer.path;
-
-import org.apache.druid.timeline.DataSegment;
-import org.joda.time.Interval;
-
-import java.io.IOException;
-import java.util.List;
+package org.apache.druid.timeline;
/**
+ * This enum is used a parameter for several methods in {@link
VersionedIntervalTimeline}, specifying whether only
+ * complete partitions should be considered, or incomplete partitions as well.
Review comment:
Since `VersionedIntervalTimeline` treats completion status mechanically
rather than semantically (that is, the implementation of
`VersionedIntervalTimeline` would be the same regardless of what `isComplete()`
semantically means), I just added reference to the method. I think Javadoc
should be added to `isComplete()` method to explain illustratively what does it
mean, but I don't feel confident about it. I've also opened issue #8788 which
is related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
