gianm commented on a change in pull request #8744: support for array
expressions in TransformSpec with ExpressionTransform
URL: https://github.com/apache/incubator-druid/pull/8744#discussion_r343346060
##########
File path: core/src/main/java/org/apache/druid/data/input/impl/ParseSpec.java
##########
@@ -64,12 +62,6 @@ public DimensionsSpec getDimensionsSpec()
return dimensionsSpec;
}
- @PublicApi
- public void verify(List<String> usedCols)
Review comment:
This `verify` method is useful for making sure that people's transforms,
dimensions, metrics, etc are derived from fields they specified (to help detect
errors & typos). But I see why you removed it -- info about transforms isn't
available at this point in the code. It probably makes sense to add this
functionality back in somehow, in a smarter way, once the dust settles on #8823.
/cc @jihoonson
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
