gianm commented on a change in pull request #8744: support for array
expressions in TransformSpec with ExpressionTransform
URL: https://github.com/apache/incubator-druid/pull/8744#discussion_r344004645
##########
File path:
processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java
##########
@@ -518,6 +513,20 @@ private static Object coerceListDimToStringArray(List val)
return new String[]{null};
}
+ /**
+ * Coerces {@link ExprEval} value back to selector friendly {@link List} if
the evaluated expression result is an
+ * array type
+ */
+ public static Object coerceEvalToSelectorObject(ExprEval eval)
+ {
+ if (eval.isArray()) {
Review comment:
If converting to a list of the base type works, let's do that, since it's
nicer.
My goal here (and w/ the other comment) is to avoid making too many places
that encode a lists-should-always-be-strings assumption. We might want to
expand that later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
