gianm commented on a change in pull request #8744: support for array
expressions in TransformSpec with ExpressionTransform
URL: https://github.com/apache/incubator-druid/pull/8744#discussion_r344004453
##########
File path:
processing/src/main/java/org/apache/druid/segment/transform/ExpressionTransform.java
##########
@@ -90,7 +92,11 @@ private static Object getValueFromRow(final Row row, final
String column)
if (column.equals(ColumnHolder.TIME_COLUMN_NAME)) {
return row.getTimestampFromEpoch();
} else {
- return row.getRaw(column);
+ Object raw = row.getRaw(column);
+ if (raw instanceof List) {
+ return ExpressionSelectors.coerceListDimToStringArray((List) raw);
Review comment:
This isn't a multi-value column, though, is it? It looks like it's something
from an input row and it could be an array of anything. I was thinking that
since expressions support numeric arrays, it'd be good to keep them that way if
found in the input rows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
