gianm commented on a change in pull request #8566: Upgrade Calcite to 1.21
URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r327736110
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -800,26 +804,29 @@ public void
testSelectProjectionFromSelectSingleColumnDescending() throws Except
{
// Regression test for
https://github.com/apache/incubator-druid/issues/7768.
+ // After upgrading to Calcite 1.21, the results return in the wrong order,
the ORDER BY __time DESC
Review comment:
Similar comment as above: the behavior is technically correct, and I think
we should roll with it. For this test, I'd suggest:
- keep the query the same
- remove this comment
- add a comment that says we're verifying that the inner order by is
stripped, as the standard allows
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
