gianm commented on a change in pull request #8566: Upgrade Calcite to 1.21
URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r348727828
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -7589,7 +7595,12 @@ public void testProjectAfterSort2() throws Exception
);
}
+ /**
+ * In Calcite 1.17, this test worked, but after upgrading to Calcite 1.21,
this query fails with:
Review comment:
Please do two things in response to this:
1. Keep this test as-is, but add a new, second test that is the same basic
query shape but doesn't trip the `dim1` is ambiguous thing. Maybe rename one of
them, or group by ordinals. Testing project after sort is still important, so
there's value in this.
2. If you think this is a Calcite bug, raise a Calcite issue at:
https://issues.apache.org/jira/projects/CALCITE/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
