gianm commented on a change in pull request #8566: Upgrade Calcite to 1.21
URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r348724455
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -3820,7 +3856,7 @@ public void testSelectDistinctWithStrlenFilter() throws
Exception
.setGranularity(Granularities.ALL)
.setVirtualColumns(
expressionVirtualColumn("v0", "strlen(\"dim1\")",
ValueType.LONG),
- expressionVirtualColumn("v1",
"CAST(strlen(\"dim1\"), 'STRING')", ValueType.STRING)
+ expressionVirtualColumn("v1",
"CAST(CAST(strlen(\"dim1\"), 'STRING'), 'LONG')", ValueType.LONG)
Review comment:
Something should be collapsing these casts. Could you add a comment to the
test that we're aware the behavior here is weird? Maybe a future developer will
see that and it will inspire them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
