gianm commented on a change in pull request #8566: Upgrade Calcite to 1.21
URL: https://github.com/apache/incubator-druid/pull/8566#discussion_r327732369
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -137,7 +141,7 @@ public void testSelectCountStart() throws Exception
ImmutableList.of(Druids.newTimeseriesQueryBuilder()
.dataSource(CalciteTests.DATASOURCE1)
.intervals(querySegmentSpec(Filtration.eternity()))
- .filters(selector("dim2", "0", null))
+ .filters(bound("dim2", "0", "0", false, false,
null, StringComparators.NUMERIC))
Review comment:
This means that instead of casting `0` to `"0"` the planner is now casting
`dim2` to numeric. Performance will be worse but it is technically more
correct. (What if `dim2` was `"0.0"`?) So, it sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
