gianm commented on a change in pull request #9235: Add join-related DataSource
types, and analysis functionality.
URL: https://github.com/apache/druid/pull/9235#discussion_r369347559
##########
File path: server/src/main/java/org/apache/druid/client/CacheUtil.java
##########
@@ -99,7 +99,8 @@
return QueryContexts.isUseCache(query)
&& strategy != null
&& cacheConfig.isUseCache()
- && cacheConfig.isQueryCacheable(query);
+ && cacheConfig.isQueryCacheable(query)
+ && query.getDataSource().isCacheable();
Review comment:
Hmm, after thinking about this a bit IMO it is best to combine
ResultLevelCacheUtil and CacheUtil, then make the change you suggested
(although I think we can only extract three lines), and then add tests for
CacheUtil. I'll add that to this patch in a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
