gianm commented on a change in pull request #9235: Add join-related DataSource
types, and analysis functionality.
URL: https://github.com/apache/druid/pull/9235#discussion_r369701195
##########
File path: processing/src/main/java/org/apache/druid/query/BaseQuery.java
##########
@@ -270,14 +270,13 @@ public boolean equals(Object o)
Objects.equals(dataSource, baseQuery.dataSource) &&
Objects.equals(context, baseQuery.context) &&
Objects.equals(querySegmentSpec, baseQuery.querySegmentSpec) &&
- Objects.equals(duration, baseQuery.duration) &&
+ Objects.equals(getDuration(), baseQuery.getDuration()) &&
Objects.equals(granularity, baseQuery.granularity);
}
@Override
public int hashCode()
{
-
- return Objects.hash(dataSource, descending, context, querySegmentSpec,
duration, granularity);
Review comment:
It's because `duration` is lazily computed, so it might be null. Calling
`getDuration()` forces it to be computed. I'll add a comment.
Btw, a lot of the subclasses of BaseQuery _do_ call `super.equals` at some
point (but they do other stuff too).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
