gianm commented on a change in pull request #9235: Add join-related DataSource
types, and analysis functionality.
URL: https://github.com/apache/druid/pull/9235#discussion_r369700275
##########
File path: processing/src/main/java/org/apache/druid/query/UnionDataSource.java
##########
@@ -52,6 +57,51 @@ public UnionDataSource(@JsonProperty("dataSources")
List<TableDataSource> dataSo
return dataSources;
}
+ @Override
+ public List<DataSource> getChildren()
+ {
+ return ImmutableList.copyOf(dataSources);
+ }
+
+ @Override
+ public DataSource withChildren(List<DataSource> children)
+ {
+ if (children.size() != dataSources.size()) {
Review comment:
It's a precondition for the method, since its intent is for replacing inputs
with inlined/etc versions, so the number of children shouldn't change. I'll add
a comment in the interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
