suneet-s commented on a change in pull request #9235: Add join-related
DataSource types, and analysis functionality.
URL: https://github.com/apache/druid/pull/9235#discussion_r369410832
##########
File path: processing/src/main/java/org/apache/druid/query/BaseQuery.java
##########
@@ -270,14 +270,13 @@ public boolean equals(Object o)
Objects.equals(dataSource, baseQuery.dataSource) &&
Objects.equals(context, baseQuery.context) &&
Objects.equals(querySegmentSpec, baseQuery.querySegmentSpec) &&
- Objects.equals(duration, baseQuery.duration) &&
+ Objects.equals(getDuration(), baseQuery.getDuration()) &&
Objects.equals(granularity, baseQuery.granularity);
}
@Override
public int hashCode()
{
-
- return Objects.hash(dataSource, descending, context, querySegmentSpec,
duration, granularity);
Review comment:
curious about why this change. I know this isn't really part of your change,
but I've also noticed equals and hashcode for a lot of classes that extend
BaseQuery have their own implementation of equals and hashCode and do not check
the base class. Sounds like we should add some equalsVerifier tests for them,
maybe in another patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
