gianm commented on a change in pull request #9235: Add join-related DataSource
types, and analysis functionality.
URL: https://github.com/apache/druid/pull/9235#discussion_r369850349
##########
File path:
processing/src/test/java/org/apache/druid/query/InlineDataSourceTest.java
##########
@@ -225,6 +225,14 @@ public void test_equals()
.verify();
}
+ @Test
+ public void test_toString_iterable()
+ {
+ // Verify that toString does not iterate the rows.
+ final String ignored = iterableDataSource.toString();
+ Assert.assertEquals(0, iterationCounter.get());
Review comment:
Any suggestions for how to improve it in a follow-up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
