suneet-s commented on a change in pull request #9235: Add join-related
DataSource types, and analysis functionality.
URL: https://github.com/apache/druid/pull/9235#discussion_r369715879
##########
File path: processing/src/main/java/org/apache/druid/query/BaseQuery.java
##########
@@ -270,14 +270,13 @@ public boolean equals(Object o)
Objects.equals(dataSource, baseQuery.dataSource) &&
Objects.equals(context, baseQuery.context) &&
Objects.equals(querySegmentSpec, baseQuery.querySegmentSpec) &&
- Objects.equals(duration, baseQuery.duration) &&
+ Objects.equals(getDuration(), baseQuery.getDuration()) &&
Objects.equals(granularity, baseQuery.granularity);
}
@Override
public int hashCode()
{
-
- return Objects.hash(dataSource, descending, context, querySegmentSpec,
duration, granularity);
Review comment:
Weird - I see the calls to `super.equals()` now, maybe I just shouldn't
read code in the night 😝
EqualsVerifier is still complaining about some other stuff. But cleaning
that up can be another issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
