suneet-s commented on a change in pull request #9274: Refactoring some codes
around ingestion
URL: https://github.com/apache/druid/pull/9274#discussion_r374240611
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentGenerateTask.java
##########
@@ -164,7 +171,11 @@ abstract T createGeneratedPartitionsReport(
final PartitionsSpec partitionsSpec =
tuningConfig.getGivenOrDefaultPartitionsSpec();
final long pushTimeout = tuningConfig.getPushTimeout();
- final IndexTaskSegmentAllocator segmentAllocator =
createSegmentAllocator(toolbox);
+ final CachingSegmentAllocator segmentAllocator =
createSegmentAllocator(toolbox, taskClient);
+ final SequenceNameFunction sequenceNameFunction = new
NonLinearlyPartitionedSequenceNameFunction(
Review comment:
Why is this always `NonLinearlyPartitionedSequenceNameFunction` shouldn't we
check the partitionsSpec type to determine the `sequenceNameFunction` here?
If it is, I think we should , make the constructors package private and
expose the function name creation through a factory that accepts a
`PartitionsSpec`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
