suneet-s commented on a change in pull request #9274: Refactoring some codes around ingestion URL: https://github.com/apache/druid/pull/9274#discussion_r374234046
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/LocalSegmentAllocator.java ########## @@ -32,32 +34,27 @@ import org.joda.time.DateTime; import org.joda.time.Interval; +import javax.annotation.Nullable; import java.io.IOException; -import java.util.HashMap; import java.util.Map; import java.util.Map.Entry; -import java.util.concurrent.atomic.AtomicInteger; import java.util.stream.Collectors; /** * Segment allocator which allocates new segments locally per request. */ -class LocalSegmentAllocator implements IndexTaskSegmentAllocator +public class LocalSegmentAllocator implements SegmentAllocator Review comment: does this need to be public? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
