jihoonson commented on a change in pull request #9274: Refactoring some codes
around ingestion
URL: https://github.com/apache/druid/pull/9274#discussion_r374439203
##########
File path:
core/src/main/java/org/apache/druid/timeline/partition/HashBasedNumberedPartialShardSpec.java
##########
@@ -27,20 +27,20 @@
import java.util.List;
import java.util.Objects;
-public class HashBasedNumberedShardSpecFactory implements ShardSpecFactory
+public class HashBasedNumberedPartialShardSpec implements PartialShardSpec
{
@Nullable
private final List<String> partitionDimensions;
- private final int numPartitions;
+ private final int numBuckets;
@JsonCreator
- public HashBasedNumberedShardSpecFactory(
+ public HashBasedNumberedPartialShardSpec(
@JsonProperty("partitionDimensions") @Nullable List<String>
partitionDimensions,
- @JsonProperty("numPartitions") int numPartitions
+ @JsonProperty("numPartitions") int numBuckets
Review comment:
👍 added a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
