sthetland commented on a change in pull request #9317: ANY Aggregator should 
not skip null values implementation
URL: https://github.com/apache/druid/pull/9317#discussion_r377813959
 
 

 ##########
 File path: docs/querying/aggregations.md
 ##########
 @@ -238,7 +238,7 @@ Note that queries with first/last aggregators on a segment 
created with rollup e
 
 (Double/Float/Long/String) ANY aggregator cannot be used in ingestion spec, 
and should only be specified as part of queries.
 
-If `druid.generic.useDefaultValueForNull=true` aggregation can returns the 
default value for null and does not prefer "non-null" values over the default 
value for null. If `druid.generic.useDefaultValueForNull=false`, then 
aggregation will returns any non-null value.
+If `druid.generic.useDefaultValueForNull=true` aggregation can returns the 
default value for null and does not prefer "non-null" values over the default 
value for null. If `druid.generic.useDefaultValueForNull=false`, then 
aggregation will returns any value including null.
 
 Review comment:
   +1 to Suneet's rewording. Agreed as well that we should add the "why". Have 
filed https://implydata.atlassian.net/browse/DOCS-30 to track. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to