clintropolis commented on a change in pull request #9317: ANY Aggregator should
not skip null values implementation
URL: https://github.com/apache/druid/pull/9317#discussion_r377942115
##########
File path: server/src/main/java/org/apache/druid/server/QueryLifecycle.java
##########
@@ -318,14 +318,12 @@ public void emitLogsAndMetrics(
if (e != null) {
statsMap.put("exception", e.toString());
-
- if (e instanceof QueryInterruptedException) {
- // Mimic behavior from QueryResource, where this code was originally
taken from.
- log.noStackTrace().warn(e, "Exception while processing queryId
[%s]", baseQuery.getId());
- statsMap.put("interrupted", true);
- statsMap.put("reason", e.toString());
- }
+ // Mimic behavior from QueryResource, where this code was originally
taken from.
Review comment:
Why this change? I don't think it is correct, since this stuff should only
be set if it was a `QueryInterruptedException`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
