clintropolis commented on a change in pull request #9317: ANY Aggregator should not skip null values implementation URL: https://github.com/apache/druid/pull/9317#discussion_r377938220
########## File path: processing/src/main/java/org/apache/druid/query/aggregation/any/NumericAnyBufferAggregator.java ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation.any; + +import org.apache.druid.common.config.NullHandling; +import org.apache.druid.query.aggregation.BufferAggregator; +import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector; +import org.apache.druid.segment.BaseNullableColumnValueSelector; + +import java.nio.ByteBuffer; + +/** + * Base type for buffer based 'any' aggregator for primitive numeric column selectors + */ +public abstract class NumericAnyBufferAggregator<TSelector extends BaseNullableColumnValueSelector> + implements BufferAggregator +{ + private static final byte BYTE_FLAG_IS_NOT_SET = 0; + private static final byte BYTE_FLAG_IS_SET = 1; + private static final int IS_FOUND_FLAG_OFFSET_POSITION = 0; + private static final int IS_NULL_FLAG_OFFSET_POSITION = IS_FOUND_FLAG_OFFSET_POSITION + Byte.BYTES; + private static final int FOUND_VALUE_OFFSET_POSITION = IS_NULL_FLAG_OFFSET_POSITION + Byte.BYTES; Review comment: nit: suggest just making this package private and having subclasses use this directly in their putValue implementations instead of `getFoundValueStoredPosition` function call, and maybe just calling it `VALUE_OFFSET` or `FOUND_VALUE_OFFSET` since the position seems redundant. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
