clintropolis commented on a change in pull request #9317: ANY Aggregator should
not skip null values implementation
URL: https://github.com/apache/druid/pull/9317#discussion_r377931492
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/any/DoubleAnyAggregator.java
##########
@@ -19,44 +19,35 @@
package org.apache.druid.query.aggregation.any;
-import org.apache.druid.query.aggregation.Aggregator;
-import org.apache.druid.query.aggregation.NullableNumericAggregator;
-import org.apache.druid.query.aggregation.NullableNumericAggregatorFactory;
import org.apache.druid.segment.BaseDoubleColumnValueSelector;
+import javax.annotation.Nullable;
+
/**
- * This Aggregator is created by the {@link DoubleAnyAggregatorFactory} which
extends from
- * {@link NullableNumericAggregatorFactory}. If null needs to be handle, then
{@link NullableNumericAggregatorFactory}
- * will wrap this aggregator in {@link NullableNumericAggregator} and can
handle all null in that class.
- * Hence, no null will ever be pass into this aggregator from the
valueSelector.
+ * This Aggregator is created by the {@link DoubleAnyAggregatorFactory} which
has no special null handling logic.
Review comment:
I'm not sure this is really worth mentioning. This is the standard case for
aggregator implementations, since it is less common for an agg implementation
to have magic null handling wrapped around it than just handling the nulls
itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
