kroeders commented on a change in pull request #10428:
URL: https://github.com/apache/druid/pull/10428#discussion_r537071548
##########
File path:
server/src/main/java/org/apache/druid/client/CachingClusteredClient.java
##########
@@ -812,7 +812,7 @@ String computeResultLevelCachingEtag(
Hasher hasher = Hashing.sha1().newHasher();
boolean hasOnlyHistoricalSegments = true;
for (SegmentServerSelector p : segments) {
- if (!p.getServer().pick().getServer().isSegmentReplicationTarget()) {
+ if
(!p.getServer().pick(null).getServer().isSegmentReplicationTarget()) {
Review comment:
I made the query change.
For the null check I was thinking for this part p.getServer().pick(query)
since we just annotated this Nullable below?
Something like -
QueryableServer queryableServer = p.getServer().pick(query);
if (queryableServer==null ||
!queryableServer.getServer().isSegmentReplicationTarget()) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
