jihoonson commented on a change in pull request #10647:
URL: https://github.com/apache/druid/pull/10647#discussion_r537684261
##########
File path: web-console/src/druid-models/ingestion-spec.tsx
##########
@@ -1546,17 +1557,41 @@ export function getPartitionRelatedTuningSpecFormFields(
},
];
+ if (oneOf(deepGet(spec, 'spec.tuningConfig.partitionsSpec.type'),
'hashed', 'single_dim')) {
+ parallelFields.push({
Review comment:
Do we need to show time intervals in the partitioning step? Seems like
we have a duplicate function in the "global filter" in the filtering step
(probably
[here](https://github.com/apache/druid/blob/f46cc4faaf9985cc1ae0d32acb945b93627d8f98/web-console/src/views/load-data-view/load-data-view.tsx#L2205-L2218)).
I prefer the intervals filter in the filtering step because it's a filter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
