vogievetsky commented on a change in pull request #10647:
URL: https://github.com/apache/druid/pull/10647#discussion_r537691781
##########
File path: web-console/src/druid-models/ingestion-spec.tsx
##########
@@ -1546,17 +1557,41 @@ export function getPartitionRelatedTuningSpecFormFields(
},
];
+ if (oneOf(deepGet(spec, 'spec.tuningConfig.partitionsSpec.type'),
'hashed', 'single_dim')) {
+ parallelFields.push({
Review comment:
You are correct and I debated taking them out of the partition step
completely but decided to leave them (redundantly) and have them folded under
`Show more`. My understanding it that setting intervals still has an effect on
how many ingestion tasks are spawned - so it is still relevant (although
unlikely) here. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
