jihoonson commented on a change in pull request #10647:
URL: https://github.com/apache/druid/pull/10647#discussion_r539519728
##########
File path: web-console/src/druid-models/ingestion-spec.tsx
##########
@@ -1546,17 +1557,41 @@ export function getPartitionRelatedTuningSpecFormFields(
},
];
+ if (oneOf(deepGet(spec, 'spec.tuningConfig.partitionsSpec.type'),
'hashed', 'single_dim')) {
+ parallelFields.push({
Review comment:
@vogievetsky and I talked offline. The `intervals` is a sort of filter
but it's actually more about partitioning. The filtering can happen as a side
effect of partitioning. The below is a quote from our doc.
> A list of intervals describing what time chunks of segments should be
created. If type is set to uniform, this list will be broken up and rounded-off
based on the segmentGranularity. If type is set to arbitrary, this list will be
used as-is.
So, we decided to move it back to the partitioning step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
