jihoonson commented on a change in pull request #10647:
URL: https://github.com/apache/druid/pull/10647#discussion_r537730401
##########
File path: web-console/src/druid-models/ingestion-spec.tsx
##########
@@ -1546,17 +1557,41 @@ export function getPartitionRelatedTuningSpecFormFields(
},
];
+ if (oneOf(deepGet(spec, 'spec.tuningConfig.partitionsSpec.type'),
'hashed', 'single_dim')) {
+ parallelFields.push({
Review comment:
I see. So, this is more for ingestion performance tuning rather than
filtering. Performance tuning guide seems nice to have. Ideally, it would be
great if it could be done in a user-friendly way in the web console, which I
have no idea on how. The best I can think of is adding a documentation for
ingestion performance tuning and linking them in the web console. Maybe we can
do it as a follow-up.
Going back to this change, it seems sort of reasonable to me in a sense that
it gives some information for performance tuning. One comment I have now is
that I was confused about how to set intervals with dynamic partitioning
because the `Show more` button doesn't show up. Maybe we can show a warning or
a hint text directly (currently the description shows up when you click the
button) that says you can make your ingestion job faster by setting intervals
in the filtering step? I know this could be a bad UX but at least consistent
across partitioning types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
