gianm commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r582966905
##########
File path:
processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java
##########
@@ -70,6 +71,11 @@ default MultiValueDimensionVectorSelector
decorate(MultiValueDimensionVectorSele
throw new UOE("DimensionSpec[%s] cannot vectorize", getClass().getName());
}
+ default VectorObjectSelector decorate(VectorObjectSelector selector)
Review comment:
Will the VectorObjectSelector passed to this method always return an
array whose values are all Strings? And is the same thing expected of the
returned VectorObjectSelector? If so, please add that to the javadoc. If not,
then I must be missing something and could you please explain it to me 🙂
By the way, what happens if the input is multi-value? Will some of the
entries in the `Object[]` of either the input or the output
VectorObjectSelector actually be `String[]` instead of `String`? Or is
multi-value not supported today?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
