gianm commented on pull request #10613: URL: https://github.com/apache/druid/pull/10613#issuecomment-786041920
Thanks for your patience, @clintropolis. Most of the remaining comments I have on the code are about clarifying the method contracts properly. At this point I wanted to ask about the testing. I haven't looked at it much, and I would deeply appreciate it if you could describe briefly what the testing strategy is for this new feature, and why you think it covers all the important cases. That'll make reviewing it a lot quicker. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
