clintropolis commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r587431712
##########
File path:
processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java
##########
@@ -62,16 +66,29 @@ default int getMaxVectorSize()
SingleValueDimensionVectorSelector
makeSingleValueDimensionSelector(DimensionSpec dimensionSpec);
/**
- * Returns a string-typed, multi-value-per-row column selector. Should only
be called on columns where
- * {@link #getColumnCapabilities} indicates they return STRING. Unlike
{@link #makeSingleValueDimensionSelector},
- * this should not be called on nonexistent columns.
+ * Returns a dictionary encoded, string-typed, multi-value-per-row column
selector. Should only be called on columns
+ * where {@link #getColumnCapabilities} indicates they return STRING. Unlike
+ * {@link #makeSingleValueDimensionSelector}, this should not be called on
nonexistent columns.
*
* If you need to write code that adapts to different input types, you
should write a
* {@link org.apache.druid.segment.VectorColumnProcessorFactory} and use one
of the
* {@link org.apache.druid.segment.ColumnProcessors#makeVectorProcessor}
functions instead of using this method.
*/
MultiValueDimensionVectorSelector
makeMultiValueDimensionSelector(DimensionSpec dimensionSpec);
+ /**
+ * Returns a dimension object selector. Useful for non-dictionary encoded
strings, or when using the dictionary
+ * isn't useful. Right now, this should probably only be called on single
valued STRING inputs (multi-value STRING
Review comment:
i got rid of this method, and merged these javadocs into the
`makeObjectSelector` javadocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
