clintropolis commented on a change in pull request #10613:
URL: https://github.com/apache/druid/pull/10613#discussion_r587432222



##########
File path: 
processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java
##########
@@ -32,4 +32,15 @@
   DruidFloatPredicate makeFloatPredicate();
 
   DruidDoublePredicate makeDoublePredicate();
+
+  /**
+   * Object predicate is currently only used by vectorized matchers for 
non-string object selectors. To preserve
+   * behavior with non-vectorized matchers which use a string predicate with 
null inputs for these 'nil' matchers,
+   * do the same thing here...
+   */
+  default Predicate<Object> makeObjectPredicate()

Review comment:
       adjusted javadocs




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to