loquisgon commented on a change in pull request #11294:
URL: https://github.com/apache/druid/pull/11294#discussion_r664966887
##########
File path: docs/configuration/index.md
##########
@@ -1334,7 +1334,7 @@ Additional peon configs include:
|`druid.peon.mode`|Choices are "local" and "remote". Setting this to local
means you intend to run the peon as a standalone process (Not
recommended).|remote|
|`druid.indexer.task.baseDir`|Base temporary working
directory.|`System.getProperty("java.io.tmpdir")`|
|`druid.indexer.task.baseTaskDir`|Base temporary working directory for
tasks.|`${druid.indexer.task.baseDir}/persistent/task`|
-|`druid.indexer.task.batchMemoryMappedIndex`|If false, native batch ingestion
will not map indexes thus saving heap space. This does not apply to streaming
ingestion, just to batch. This setting should only be used when a bug is
suspected or found in the new batch ingestion code that avoids memory mapping
indices. If a bug is suspected or found, you can set this flag to `true` to
fall back to previous, working but more memory intensive, code path.|`false`|
+|`druid.indexer.task.batchFallback`|If false, native batch ingestion will use
memory optimized code. This does not apply to streaming ingestion, just to
batch. This setting should only be used when a bug is suspected or found in the
new optimized batch ingestion code. If a bug is suspected or found, you can set
this flag to `true` to fall back to previous, working but more memory
intensive, code path.|`false`|
Review comment:
I intentionally left that variable with a vague name...if the previous
that I just removed would have had a vague name like that then I could have
just re-used it and maybe edit the description in the docs. I feel this name is
fine (I accept it is vague--which is intentional) since it is really there for
an exceptional situation. We want to get rid of this asap, potentially before
the next open source release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
